Open
Conversation
JEnoch
force-pushed
the
tests_isolation_for_zenoh
branch
from
736c576 to
ffcded4
Compare
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
overall lgtm.
- we need to rebase this dev branch to build.
- a couple of minor comments to be resolved.
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
…oh router Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
JEnoch
force-pushed
the
tests_isolation_for_zenoh
branch
from
c7467c3 to
3f63083
Compare
Author
|
Done. Thanks for your review! I guess the failing build caused by |
Collaborator
|
Pulls: #1291
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in ros2/rmw_zenoh#881 (comment), this PR adds tests isolation:
rcl_actionusingament_add_ros_isolated_gtest_testin CMakeLists.txtrcl/test_rmw_impl_id_checksettingZENOH_CONFIG_OVERRIDEto not attempt connection to any router.Is this user-facing behavior change?
No
Did you use Generative AI?
No